New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networks-inject reports success even if it couldn't inject addresse #32

Open

fleupold opened this issue Jun 30, 2020 · 1 comment

Labels

bug

Contributor

fleupold commented Jun 30, 2020

also I found a clear bug that if you make empty build/contracts and run yarn run networks-inject it will say that all is fine, but do nothing

If we cannot inject the addresses into the contracts we should fail the script and let the user know.

fleupold added the bug label

Contributor

bh2smith commented Jun 30, 2020

Not sure if this is the desired solution, but perhaps we could run a build right before the injection script in package.json

util-contracts/package.json

Line 13 in fd08cb5

"networks-inject": "node src/inject_network_info.js",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment