Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubbling Error reason when verifying #14

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Bubbling Error reason when verifying #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a2d75
feat: do not swallow error result, when calling "verifysourcecode"
cristovaoth Aug 27, 2024
23ccffe
chore: bump version
cristovaoth Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@gnosis-guild/zodiac-core",
"version": "2.0.0",
"version": "2.0.1",
"description": "Zodiac is a composable design philosophy and collection of standards for building DAO ecosystem tooling.",
"author": "Auryn Macmillan <[email protected]>",
"license": "LGPL-3.0+",
Expand Down
5 changes: 3 additions & 2 deletions src/artifact/internal/etherscan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,14 @@ export async function verifySourceCode({
},
body: parameters.toString(),
});
const { status, message } = (await response.json()) as {
const { status, message, result } = (await response.json()) as {
status: number;
message: string;
result: string;
};

if (!isOk(status)) {
throw new Error(`Verification Error: ${status} ${message}`);
throw new Error(`Verifying SourceCode: ${message} ${result}`);
}

return {
Expand Down
Loading