Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zodiac Reality Module stuck, doesn't allow to continue after filling in name #198

Open
greenlucid opened this issue Mar 21, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@greenlucid
Copy link
Contributor

greenlucid commented Mar 21, 2023

Describe the bug

I can't get through the first step of the Zodiac Reality Module wizard, in which it asks for an ENS

To Reproduce
Steps to reproduce the behavior:

  1. Connect to Safe, in Mainnet
  2. Open Zodiac App
  3. Open Reality Module
  4. Write in an ENS for a Snapshot the Safe controls
  5. (bug occurs)

Expected behavior

I was expected to stumble upon this #194 since the PR with the fix wasn't merged yet, but it doesn't do anything, with the button remaining disabled.

Even if it froze, I would've expect some kind of error to appear in the console, or some network request to fetch something from snapshot, but that wasn't the case either. It's just unreactive.

Screenshots / logs

image

Relevant environment details:

Same as the other issues I've reported. Frame Wallet.

Additional context

None

@greenlucid greenlucid added the bug Something isn't working label Mar 21, 2023
@greenlucid
Copy link
Contributor Author

greenlucid commented Mar 21, 2023

Investigated a bit through the network log, it's making requests here:
https://hub.snapshot.org/api/spaces/tralara.eth/poke
But this endpoint is returning error 307. When you access the following endpoint, then it seems to be valid:
https://hub.snapshot.org/api/spaces/tralara.eth

Offending function: https://github.com/gnosis/zodiac-safe-app/blob/b596798d5073da7a4850b974eaec3f2f14e52ffb/packages/app/src/services/snapshot.ts#L28

Not poking seems to solve the issue

@greenlucid
Copy link
Contributor Author

Pasting a Discord conversation in https://discord.gg/snapshot #developers channel that could shed some light

green

Yesterday at 3:42 PM
hey, is the following endpoint valid? https://hub.snapshot.org/api/spaces/tralara.eth/poke
it's returning error code 307. a query is being made from Reality Module, a subapp in the Zodiac Module app in app.safe.global

green

Yesterday at 4:11 PM
related issue: #198 (comment)
Is it still true that calling /poke refreshes the cache of the snapshot space data, or is this behavior no longer the case?

Chaitu⚡

Yesterday at 6:34 PM
Hey @green Yes it is still valid, but can be useful for this case https://docs.snapshot.org/user-guides/spaces/create/alternative-way-to-create-a-space
It should not have any relation to zodiac, as you mentioned in comment https://hub.snapshot.org/api/spaces/tralara.eth
can be used to get the space, even better if they use https://docs.snapshot.org/tools/graphql-api#space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants