Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbinding a buffer is a method #177

Open
viking opened this issue Dec 29, 2014 · 2 comments
Open

Unbinding a buffer is a method #177

viking opened this issue Dec 29, 2014 · 2 comments

Comments

@viking
Copy link

viking commented Dec 29, 2014

Buffer.Bind() is a method, but makes no use of the buffer object. Is this intended?

https://github.com/go-gl/gl/blob/a521f6d83a0c82047d49328a275acbb98b5dc4fe/buffer.go#L49

@ghost
Copy link

ghost commented Dec 30, 2014

Blame shows this was my doing. The reason being consistency with the same pattern on other types in the package. I also recall it feeling rather weird that Bind was a method and Unbind was not.

One can argue this is a matter of taste, but I figured we had to be consistent across the board and thus had to make a choice one way or the other.

@pwaller
Copy link
Contributor

pwaller commented Dec 30, 2014

I'm confused. Did you mean Unbind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants