diff --git a/logger/sql.go b/logger/sql.go index 7cfbd0ab1..13e5d957d 100644 --- a/logger/sql.go +++ b/logger/sql.go @@ -28,7 +28,7 @@ func isPrintable(s string) bool { return true } -// TODO: +// A list of Go types that should be converted to SQL primitives var convertibleTypes = []reflect.Type{reflect.TypeOf(time.Time{}), reflect.TypeOf(false), reflect.TypeOf([]byte{})} // RegEx matches only numeric values diff --git a/migrator/migrator.go b/migrator/migrator.go index 98a3a6dbb..b15a43ef2 100644 --- a/migrator/migrator.go +++ b/migrator/migrator.go @@ -25,6 +25,8 @@ import ( // -"%$#@789" var regFullDataType = regexp.MustCompile(`\D*(\d+)\D?`) +// TODO:? Create const vars for raw sql queries ? + // Migrator m struct type Migrator struct { Config diff --git a/tests/go.mod b/tests/go.mod index be9d6246f..7a89ee053 100644 --- a/tests/go.mod +++ b/tests/go.mod @@ -23,7 +23,7 @@ require ( github.com/jinzhu/inflection v1.0.0 // indirect github.com/mattn/go-sqlite3 v1.14.17 // indirect github.com/microsoft/go-mssqldb v1.5.0 // indirect - golang.org/x/crypto v0.11.0 // indirect + golang.org/x/crypto v0.12.0 // indirect golang.org/x/text v0.12.0 // indirect ) diff --git a/tests/tests_all.sh b/tests/tests_all.sh index ed5878408..ee9e76754 100755 --- a/tests/tests_all.sh +++ b/tests/tests_all.sh @@ -15,22 +15,6 @@ then cd .. fi -# Function for checking if binary is installed -check_binary() { - if ! which "$1" > /dev/null; then - ( >&2 echo "$2" ) - # Exit with a nonzero code so that the caller knows the script failed. - exit 1 - fi -} - -check_binary "sqlcmd" "$(cat <