Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom types #2

Open
iamyashrs opened this issue Apr 4, 2018 · 0 comments
Open

Custom types #2

iamyashrs opened this issue Apr 4, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@iamyashrs
Copy link
Member

Right now, we haven't defined custom types for Quota, Class and StationCode fields of Requests. This decision has been taken as we don't want to limit the user's in future in their use of the library.

A proposal is to define custom types for these fields. And since they would be an alias of Go's inbuild types, they can be easily used.

type Quota string
type Class string
type StationCode string

This decision is pending. Discussions are always welcomed.
@iamyashrs iamyashrs added the enhancement New feature or request label Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamyashrs