Skip to content

Audit for domain-unsafe global code #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
10 tasks
sim642 opened this issue Apr 17, 2025 · 1 comment
Open
10 tasks

Audit for domain-unsafe global code #1730

sim642 opened this issue Apr 17, 2025 · 1 comment
Labels
parallel Parallel Goblint

Comments

@sim642
Copy link
Member

sim642 commented Apr 17, 2025

Initial list from #1708 reviews, but could be extended over time:

  • Top-level lazy values:
    • Offset.Index.Exp.all
    • Cilfacade.any_index_exp
    • LibraryFunctions.intmax_t
  • Top-level ref values.
  • ResettableLazy and its usages.
  • LazyEval and its usages.
  • Output streams:
    • Logs
    • Messages
@sim642 sim642 added the parallel Parallel Goblint label Apr 17, 2025
@arkocal
Copy link
Contributor

arkocal commented Apr 17, 2025

In addition, we can consider marking features/analysis as domain-safe or note.

AFAIK, not all analyses consist only of pure functions, and it might be tricky to change this everywhere. In such cases, it should be marked and we should check for inconsistent configs at startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parallel Parallel Goblint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sim642 @arkocal