Add move! #26
Open
Add move! #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroseman
previously requested changes
Feb 9, 2021
ivgiuliani
reviewed
Feb 9, 2021
JoeSouthan
force-pushed
the
joesouthan/move-file
branch
2 times, most recently
from
5a7278a to
c53dfe6
Compare
JoeSouthan
force-pushed
the
joesouthan/move-file
branch
from
c53dfe6 to
084dfbf
Compare
ivgiuliani
reviewed
May 26, 2021
| old_file = get_bucket(bucket).file(key) | ||
| destination_bucket = get_bucket(new_bucket) | ||
| file.copy(destination_bucket.name, new_key) | ||
| old_file.delete |
There was a problem hiding this comment.
Do we need to delete the folder as well if this was the only file left inside? I imagine the real case here is that we don't want to see the folder in the list output if it's empty (since it wouldn't happen in services like GCS)
JoeSouthan
force-pushed
the
joesouthan/move-file
branch
2 times, most recently
from
add589d to
831dd05
Compare
JoeSouthan
force-pushed
the
joesouthan/move-file
branch
from
831dd05 to
ec3af1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move file from one place to another