Skip to content

Commit

Permalink
Change how rules are referenced (#124)
Browse files Browse the repository at this point in the history
These ones should be prefixed by RSpec as otherwise we get an error

![image](https://github.com/gocardless/gc_ruboconfig/assets/5471469/72ead511-01e3-4b39-a5e9-6179920afdde)
  • Loading branch information
kevinrobayna authored Jul 10, 2024
1 parent e312ff7 commit 22e7943
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
11 changes: 5 additions & 6 deletions capybara.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@ require:
- rubocop-capybara

# new in 2.13
Capybara/SpecificFinders:
RSpec/Capybara/SpecificFinders:
Enabled: true

# new in 2.12
Capybara/SpecificMatcher:
RSpec/Capybara/SpecificMatcher: # new in 2.12
Enabled: true
Capybara/NegationMatcher: # new in 2.14

RSpec/Capybara/NegationMatcher: # new in 2.14
Enabled: true

Capybara/SpecificActions: # new in 2.14
RSpec/Capybara/SpecificActions: # new in 2.14
Enabled: false
2 changes: 1 addition & 1 deletion gc_ruboconfig.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Gem::Specification.new do |spec|
spec.name = 'gc_ruboconfig'
spec.version = '5.0.0'
spec.version = '5.0.1'
spec.summary = "GoCardless's shared Rubocop configuration, conforming to our house style"
spec.authors = %w[GoCardless]
spec.homepage = 'https://github.com/gocardless/ruboconfig'
Expand Down
4 changes: 2 additions & 2 deletions rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ RSpec/SortMetadata: # new in 2.14
Enabled: true

# Seems to be buggy, causes an infinite loop for `subjects` named `create`
FactoryBot/ConsistentParenthesesStyle: # new in 2.14
RSpec/FactoryBot/ConsistentParenthesesStyle: # new in 2.14
Enabled: false

Style/AndOr:
Expand All @@ -665,4 +665,4 @@ Style/AndOr:

# Autocorrect is a little simplified and can lead to confusion
RSpec/ExampleWording:
Enabled: false
Enabled: false

0 comments on commit 22e7943

Please sign in to comment.