Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomerCreateRequest.withMetadata() is using pre 5.18.1 signature of MetaData #109

Open
grafjo opened this issue Jun 24, 2023 · 1 comment

Comments

@grafjo
Copy link

grafjo commented Jun 24, 2023

In Release 5.18.1 introduced MetaData Map with signature Map<String, Object>

You missed adjusting CustomerService CustomerCreateRequest.withMetadata(Map<String, String> metadata) - this is still using the old signature - see https://github.com/gocardless/gocardless-pro-java/blob/master/src/main/java/com/gocardless/services/CustomerService.java#L201

@Nimisoere
Copy link
Contributor

Hey @grafjo ,

Thanks for sending this over. We are working on a fix to properly generate types for generic objects based on schema pattern properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants