Allow NULL as valid parameter for isRetryableServerError #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was a server error that caused GoCardless API requests to fail, the GC library was failing to handle the error correctly due to a mistake in the function signature.
I was getting errors like this:
The problem was that calling that method with an argument whose value is NULL is not allowed by the function signature.
This PR adds a ? before the type hint, which fixes the problem, the code is now valid and when circumstances arise (like network failures) the error can be properly handled and reported.