Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code error resources.MandateRequestConstraints #84

Closed
blaggacao opened this issue Jul 10, 2023 · 1 comment
Closed

code error resources.MandateRequestConstraints #84

blaggacao opened this issue Jul 10, 2023 · 1 comment

Comments

@blaggacao
Copy link

v1.45.0 is affcted.

https://github.com/gocardless/gocardless-pro-python/blob/62fbef3a116b8ce5ad5f174f212c10a54698107c/gocardless_pro/services/mandate_request_constraints_service.py#L16C51-L16C51

python3.10-gocardless-pro>     RESOURCE_CLASS = resources.MandateRequestConstraints
python3.10-gocardless-pro> AttributeError: module 'gocardless_pro.resources' has no attribute 'MandateRequestConstraints'

It is effectively not exported. Seems like crank didn't run or make a mistake.
@blaggacao blaggacao changed the title code error code error resources.MandateRequestConstraints Jul 10, 2023
@hjheath
Copy link
Contributor

hjheath commented Sep 19, 2023

I've just removed this resource from the library in #88

This resources was added mistakenly and crank did not remove it when we removed it. You can still specify and access the mandate[request_constraints] field on the billing request resource.

@hjheath hjheath closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjheath @blaggacao