diff --git a/internal/certs/certs_test.go b/internal/certs/certs_test.go index eb4d4d13..46323d03 100644 --- a/internal/certs/certs_test.go +++ b/internal/certs/certs_test.go @@ -6,48 +6,50 @@ import "testing" // valid certificates and throws an error at invalid certificates, // keys or passphrases func TestLoadCertificates(t *testing.T) { - testCert := "data/testclient.crt" - testKey := "data/testclientkey.pem" - passphrase := "qwer" - missingCert := "data/testclientcert_missing.crt" - missingTestkey := "data/testclientkey_missing.pem" - privateKey := "data/privated.pem" - privateCert := "data/cert.crt" + var ( + testCert = "data/testclient.crt" + testKey = "data/testclientkey.pem" + passphrase = "qwer" + missingCert = "data/testclientcert_missing.crt" + missingTestkey = "data/testclientkey_missing.pem" + privateKey = "data/privated.pem" + privateCert = "data/cert.crt" + ) - // Try to load certificate that is not protected, expect success. - if certificate, err := LoadCertificate(&testCert, &testKey, nil); certificate == nil || err != nil { + // Try to load cert that is not protected, expect success. + if cert, err := LoadCertificate(&testCert, &testKey, nil); cert == nil || err != nil { t.Errorf("Failure: Couldn't load supposedly valid certificate.") } - // Try to load no certificate, expect error. - if certificate, err := LoadCertificate(nil, &testKey, nil); certificate != nil || err == nil { + // Try to load no cert, expect error. + if cert, err := LoadCertificate(nil, &testKey, nil); cert != nil || err == nil { t.Errorf("Failure: No error despite missing certificate") } - // Try to load certificate using a nonexistent key, expect error. - if certificate, err := LoadCertificate(&testCert, &missingTestkey, nil); certificate != nil || err == nil { + // Try to load cert using a nonexistent key, expect error. + if cert, err := LoadCertificate(&testCert, &missingTestkey, nil); cert != nil || err == nil { t.Errorf("Failure: No Failure while loading certificate using missing key.") } - // Try to decrypt not encrypted certificate, expect error - if certificate, err := LoadCertificate(&testCert, &testKey, &passphrase); certificate != nil || err == nil { + // Try to decrypt not encrypted cert, expect error + if cert, err := LoadCertificate(&testCert, &testKey, &passphrase); cert != nil || err == nil { t.Errorf("Failure: Could load unprotected valid certificate with passphrase.") } - // Try to load encrypted certificate using a nonexistent key, but valid passphrase. Expect error. - if certificate, err := LoadCertificate(&testCert, &missingTestkey, &passphrase); certificate != nil || err == nil { - t.Errorf("Failure: No Failure while loading certificate using missing key with passphrase.") + // Try to load encrypted cert using a nonexistent key, but valid passphrase. Expect error. + if cert, err := LoadCertificate(&testCert, &missingTestkey, &passphrase); cert != nil || err == nil { + t.Errorf("Failure: No Failure while loading certificate using missing key with passphrase.") } - // Try to load encrypted certificate, expecting success. - if certificate, err := LoadCertificate(&privateCert, &privateKey, &passphrase); certificate == nil || err != nil { + // Try to load encrypted cert, expecting success. + if cert, err := LoadCertificate(&privateCert, &privateKey, &passphrase); cert == nil || err != nil { t.Errorf("Failure: Couldn't load supposedly valid encrypted certificate.") } - // Try to load wrong encrypted certificate, expecting error. - if certificate, err := LoadCertificate(&testKey, &privateKey, &passphrase); certificate != nil || err == nil { - t.Errorf("Failure: No Failure while loading certificate using wrong encrypted key.") + // Try to load wrong encrypted cert, expecting error. + if cert, err := LoadCertificate(&testKey, &privateKey, &passphrase); cert != nil || err == nil { + t.Errorf("Failure: No Failure while loading certificate using wrong encrypted key.") } - // Try to load nonexistent encrypted certificate, expecting error. - if certificate, err := LoadCertificate(&missingCert, &privateKey, &passphrase); certificate != nil || err == nil { - t.Errorf("Failure: No Failure while loading nonexistens certificate.") + // Try to load nonexistent encrypted cert, expecting error. + if cert, err := LoadCertificate(&missingCert, &privateKey, &passphrase); cert != nil || err == nil { + t.Errorf("Failure: No Failure while loading nonexistens certificate.") } - // Try to load nonexistent encrypted certificate, expecting error. - if certificate, err := LoadCertificate(nil, nil, nil); certificate != nil || err != nil { - t.Errorf("Failure: Expected nil return.") + // Try to load nonexistent encrypted cert, expecting error. + if cert, err := LoadCertificate(nil, nil, nil); cert != nil || err != nil { + t.Errorf("Failure: Expected nil return.") } } diff --git a/internal/filter/filter_test.go b/internal/filter/filter_test.go index 775a14b0..0ac3438c 100644 --- a/internal/filter/filter_test.go +++ b/internal/filter/filter_test.go @@ -22,7 +22,7 @@ func TestNewPatternMatcher(t *testing.T) { } regex = append(regex, "++") if pm, err := NewPatternMatcher(regex); pm != nil || err == nil { - t.Errorf("Failure: No error thrown at invalid compile pattern") + t.Errorf("Failure: No error returned at invalid compile pattern") } } diff --git a/internal/misc/doc_test.go b/internal/misc/doc_test.go deleted file mode 100644 index 1fec00ae..00000000 --- a/internal/misc/doc_test.go +++ /dev/null @@ -1,10 +0,0 @@ -// This file is Free Software under the MIT License -// without warranty, see README.md and LICENSES/MIT.txt for details. -// -// SPDX-License-Identifier: MIT -// -// SPDX-FileCopyrightText: 2023 German Federal Office for Information Security (BSI) -// Software-Engineering: 2023 Intevation GmbH - -// Package misc implements miscellaneous helper functions. -package misc diff --git a/internal/misc/mime_test.go b/internal/misc/mime_test.go index 043e5453..bd5a31c2 100644 --- a/internal/misc/mime_test.go +++ b/internal/misc/mime_test.go @@ -9,7 +9,7 @@ package misc import ( - "bytes" + "io" "mime/multipart" "testing" ) @@ -17,8 +17,7 @@ import ( // TestCreateFormFile tests if CreateFormFile throws an error when creating // a FormFile func TestCreateFormFile(t *testing.T) { - body := new(bytes.Buffer) - writer := multipart.NewWriter(body) + writer := multipart.NewWriter(io.Discard) if _, err := CreateFormFile(writer, "csaf", "data", "application/json"); err != nil { t.Errorf("Failure: failed to create an io.Writer via CreateFormFile") diff --git a/internal/options/options_test.go b/internal/options/options_test.go index 0758b771..06ff93f0 100644 --- a/internal/options/options_test.go +++ b/internal/options/options_test.go @@ -92,8 +92,8 @@ func TestLoadToml(t *testing.T) { t.Errorf("Failure: Didn't throw the correct " + "error on trying to load nonexistant file") } - if err := loadTOML(&cfg, "data/config_plus.toml"); err.Error() != "could not parse [\"surplus\"] "+ - "from \"data/config_plus.toml\"" { + const errMsg = `could not parse ["surplus"] from "data/config_plus.toml"` + if err := loadTOML(&cfg, "data/config_plus.toml"); err.Error() != errMsg { t.Errorf("Failure: Succeeded in parsing nonexistant parameter") } if err := loadTOML(&cfg, "data/config.toml"); err != nil {