Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No files checked for current year #471

Closed
tschmidtb51 opened this issue Sep 28, 2023 · 2 comments · Fixed by #472
Closed

No files checked for current year #471

tschmidtb51 opened this issue Sep 28, 2023 · 2 comments · Fixed by #472

Comments

@tschmidtb51
Copy link
Collaborator

It looks like no files are checked if the csaf_checker should investigate the current year only.

Steps to reproduce:
Use the csaf_checker on a valid CSAF trusted provider with the option -t 2023.
If the -v option is used, it should result in listing the CSAF files retrieved.
However, no files were retrieved and also no signatures/hashes checked.

Tested with 3.0.0-beta1-g1

@tschmidtb51 tschmidtb51 added csaf_checker investigation_needed This item needs investigation labels Sep 28, 2023
@s-l-teichmann
Copy link
Contributor

The problem arises from the folder of year check and the constructed time interval by the -t flag.

-t 2023 creates a time interval from the beginning of the year and now. 2023 is not over now.

The folder year check tests if the last second of the year is in that interval. This is not the case so the advisory gets skipped.

The test has to be changed in a way to check if the whole years interval has an overlap with the time interval.

@s-l-teichmann s-l-teichmann linked a pull request Sep 29, 2023 that will close this issue
@s-l-teichmann
Copy link
Contributor

PR #472 should fix this

@s-l-teichmann s-l-teichmann removed the investigation_needed This item needs investigation label Sep 29, 2023
@bernhardreiter bernhardreiter added this to the Release 3.0.0-beta2 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants