-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix licensing info for generated files #542
Conversation
* change generate_cvss_enums.go to note that the input file is relevant for the license. * change license and copyright of cvss20enums.go and cvss3enums.go to BSD-3-Clause and FIRST. * add reuse.software 3.0 compatible files for the schema cvss files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM & works
I might have missed that. Why is it assumed to be BSD-3clause? |
The input files are licensed under And see comment in the improved generate_cvss_enums.go: // We from Intevation consider the source code parts in the following
// template file as too insignificant to be a piece of work that gains
// "copyrights" protection in the European Union. So the license(s)
// of the output files are fully determined by the input file. |
@s-l-teichmann ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correctly used.
Running go generate ./...
in the root folder results in a diff
diff --git a/csaf/cvss20enums.go b/csaf/cvss20enums.go
index 97d2e10..d7c647d 100644
--- a/csaf/cvss20enums.go
+++ b/csaf/cvss20enums.go
@@ -1,5 +1,4 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: 2017 FIRST.ORG, INC.
+// determine license(s) from input file and replace this line
//
// THIS FILE IS MACHINE GENERATED. EDIT WITH CARE!
diff --git a/csaf/cvss3enums.go b/csaf/cvss3enums.go
index 32e01e3..1367820 100644
--- a/csaf/cvss3enums.go
+++ b/csaf/cvss3enums.go
@@ -1,5 +1,4 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: 2017 FIRST.ORG, INC.
+// determine license(s) from input file and replace this line
//
// THIS FILE IS MACHINE GENERATED. EDIT WITH CARE!
There should be no diff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer a diff
LGTM & works
resolves #534