Replies: 3 comments
-
Rename AA: AA is for this category to no longer be an Outlier, but consistent with itself and the API as a whole. BaseButton: WebXRInterface: TouchScreenButton: XRController3D: XRPositionalTracker: |
Beta Was this translation helpful? Give feedback.
-
Rename BB: BB is for using released and invoked. BaseButton: WebXRInterface: |
Beta Was this translation helpful? Give feedback.
-
For these particular signal names, it is a letter-for-letter match! See: https://github.com/godotengine/godot/blob/3.x/modules/webxr/native/library_godot_webxr.js#L282 My goal was for the API to stick as closely to the JS API as we could for everything that didn't need to conform to Godot's XR APIs, so that we could simply reference the JS API for any questions about how it worked. If there are places where we aren't matching the JS API, I'd actually more prefer to go the other way, and change |
Beta Was this translation helpful? Give feedback.
-
The press API has not aged well as similar APIs have been added with inconsistent names.
My reasoning for consistency (weighed against each other): Reduced confusion (what timing? differentiated verb), consistent implied details (started what? cognitive load), cleaner reusable code (can: n in variant group: n.enabled = true), ease of knowing more features (A == B, A or B needed?), reduced double negatives, and reduced typing.
The press category (includes select & squeeze) is currently an Outlier from API naming. It is subjective if their category difference is justified based on how someone prioritizes the above competing reasons.
This Proposal is for the category to be consistent within itself, for the above reasons.
Note: WebXRInterface is already not a letter for letter match of JS API.
Beta Was this translation helpful? Give feedback.
All reactions