Use increment instead of conditional_increment for SafeRefCount.
#102977
+80
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
refcount-h00ray
branch
from
d865c5b to
64ba926
Compare
This simplifies `ref` calls to always succeed, eliminating logic. This commit introduces an edge case where the 2^32th reference will result in rollover, accidentally deallocating the object in question.
Ivorforce
force-pushed
the
refcount-h00ray
branch
from
64ba926 to
a4c0343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#11795.
This simplifies
SafeRefCount::refcalls to always succeed, eliminating logic.In particular, this PR will speed up
RefCounted::init_refcalls (nowreference), e.g. improvingGDScriptfunction call overhead by ~4%.It should also slightly improve speed and reduce code of
referencecalls in general.Caveats
This commit introduces an edge case where the 2^32th reference will result in rollover, accidentally deallocating the object in question early.
It is unlikely this edge case is ever triggered for a real scenario, because 2^32 references would be 32GB of packed references (â 8 bytes), which is obviously nuts.