Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to all migrators #1183

Open
ccoVeille opened this issue Nov 10, 2024 · 3 comments
Open

Add context to all migrators #1183

ccoVeille opened this issue Nov 10, 2024 · 3 comments
Labels
Datasource enhancement New feature or request

Comments

@ccoVeille
Copy link
Contributor

As per discussed here

passing context is a better option for all other datasource migrators as our migrator interface doesn't have context as paramter in the following methods:

type migrator interface {
	checkAndCreateMigrationTable(c *container.Container) error
	getLastMigration(c *container.Container) int64

	beginTransaction(c *container.Container) transactionData

	commitMigration(c *container.Container, data transactionData) error
	rollback(c *container.Container, data transactionData)
}
@ccoVeille
Copy link
Contributor Author

But we have to wait for this one to be merged

@aryanmehrotra aryanmehrotra added enhancement New feature or request Datasource labels Nov 15, 2024
@afzal442
Copy link

Hi, I would like to take this up. This is going to be a straightforward upgrade. Right?

@afzal442
Copy link

cc @coolwednesday @aryanmehrotra any thought?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datasource enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants