Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BasicAuthMiddleware #996

Open
aryanmehrotra opened this issue Sep 6, 2024 · 10 comments · May be fixed by #1203
Open

Refactor BasicAuthMiddleware #996

aryanmehrotra opened this issue Sep 6, 2024 · 10 comments · May be fixed by #1203
Assignees
Labels
codeclimate go Pull requests that update Go code good first issue Good for newcomers

Comments

@aryanmehrotra
Copy link
Member

Function BasicAuthMiddleware has a Cognitive Complexity of 19 (exceeds 12 allowed).

Refer : https://codeclimate.com/github/gofr-dev/gofr/issues?category=complexity&engine_name%5B%5D=structure&engine_name%5B%5D=duplication

@aryanmehrotra aryanmehrotra added good first issue Good for newcomers go Pull requests that update Go code codeclimate labels Sep 6, 2024
@iamshubha
Copy link

@aryanmehrotra Please assign this issue to me

@kuldeep-bishnoi
Copy link

Hi @aryanmehrotra
I would like to work on this issue. Could you please assign it to me?

@srijan-27
Copy link
Contributor

@kuldeep-bishnoi - This is already assigned to @iamshubha, so can't assign this to you as of now.. if Shubha doesn't pick this up then maybe you can work on this.

@vipul-rawat
Copy link
Member

@iamshubha Are you working on this, Please raise a PR or we would have to unassign this issue.

@Umang01-hash
Copy link
Contributor

@iamshubha unassigning the issue to you because of unactiveness and no reply.

@kuldeep-bishnoi would you like to work on it ?

@nidhey27
Copy link

@Umang01-hash I've refactored the BasicAuthMiddleware function to reduce its cognitive complexity. When you have a moment, could you please review the changes? I’d appreciate any feedback on the refactor or suggestions for further improvement.

@Umang01-hash
Copy link
Contributor

Sure @nidhey27 we will review it and let you know about any changes if needed.

@nidhey27
Copy link

@Umang01-hash do you guys have slack channel or anything for communication with maintainer?

@coolwednesday
Copy link
Contributor

coolwednesday commented Nov 27, 2024

@Umang01-hash do you guys have slack channel or anything for communication with maintainer?

Hey @nidhey27 , you can join our Discord channel and create a discussion.....
Also since I see inactivity on your side, can I pick this issue up ?

@nidhey27
Copy link

Cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codeclimate go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants