Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should work even if no project_depth, artifact_depth is provided? #29

Open
ramaprakashganesan opened this issue Feb 11, 2018 · 1 comment

Comments

@ramaprakashganesan
Copy link

count_based_retention seems to need project_depth and artifact_depth specified explicitly for it to work. Would make sense if it automatically figured that for any depth?
By default, it would just need to drill down to the folder where the actual artifacts (files) are present, and the parent folder would basically be the 'version folder'. This would help for most repos types and layouts these days - Maven, Docker, Gradle, etc.
Of course, the option to provide these parameters could still remain.

@ndcampbell
Copy link
Member

@ramaprakashganesan - It would be really useful for some repositories to be able to just drill down to find the actual artifacts. The reason this required specification is because in our use-cases, sometimes we wanted "artifact_depth" to point to the files, and sometimes it needed to point to the versioned directory, depending on the type of repository and what we wanted to clean up. I originally tried to make it just automatically drill down and had a hard time making it work for all of our repositories and I just never revisited the implementation.

If you have a good way to do this, I'd certainly welcome a PR.

I may try to poke at this too, as it is a feature I'd like to offer, but I can not commit to any timeline on getting it done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants