Feature/private modmap #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The framework exposes OpenSSL to the consuming application, that is an unnecessary implementation detail. All the OpenSSL headers have been exported by the framework. Changed them from being `public` to `private` headers. Add a supporting private module map (the empty public modmap needs to stay!) Needless to say that I didn't test that in any way, can't have everything ;-)
Was IAP_iOS which didn't exist or compile, is IAP now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The framework exposes OpenSSL to the consuming
application, that is an unnecessary implementation
detail.
Description
All the OpenSSL headers have been exported by the
framework. Changed them from being
publictoprivateheaders.Add a supporting private module map (the empty
public modmap needs to stay!)
How to Test
Test whether it still works as it used to. If not, let me know and I'll have a another look.
Merge Checklist