Enhancements/disable retry on no network #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/Clickstream/EventScheduler/Core/EventBatchProcessor.swift
Outdated
Show resolved
Hide resolved
…ents/disable_retry_on_no_network
remove unused function
…d_events Record number of events dropped at the end for retry mechanims
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry mechanism keep trying to push batched and increment the counter even if network is not available. Once the retry limit is reached, these events are dropped.
To fix this, we add a network availability check to stop incrementing the retry counter if network is not available. This keeps the event batch in db for future data push and also stops making unnecessary API calls if network is not available.