New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests are being hardcoded to get close after response #121

Open

Matias-Barrios opened this issue Aug 5, 2021 · 1 comment

Contributor

Matias-Barrios commented Aug 5, 2021

hello folks, why is this line hardcoded?

heimdall/httpclient/client.go

Line 125 in ca8c352

request.Close = true

It's stopping me from reusing the connections which might improve the performance of my app.

Contributor Author

Matias-Barrios commented Aug 5, 2021

I have created a PR for this : https://github.com/gojek/heimdall/pull/122/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment