Hystrix http client - Unit missing in configuration

[aaditya-khetan]

• The hystrix client uses SleepWindow config in integer instead of time.Duration field - https://github.com/gojek/heimdall/blob/master/hystrix/hystrix_client.go#L29
• This leads to confusion whether this value is expected in seconds or milliseconds.
• Moreover, there is no documentation mentioning the expected unit either in readme or in code comments which leds to a lot of back and forth in integrating and successfully testing the CB configs.

[lyn1505]

I'm having the same confusion. If I'm correct, there's an inconsistent here: Heimdall interprets SleepWindow as in seconds, while afex/hystrix-go, the circuit breaker Heimdall is using, interprets it in milliseconds.

Default value is 10 in Heimdall: https://github.com/gojek/heimdall/blob/master/hystrix/hystrix_client.go#L43
Default value is 5000 (5 sec) in afex/hystrix-go: https://github.com/afex/hystrix-go/blob/master/hystrix/settings.go#L16