Skip to content

Commit ea30ca7

Browse files
authored
Support external tracing deployment (#86)
closes #83
1 parent 4d788c2 commit ea30ca7

File tree

3 files changed

+17
-0
lines changed

3 files changed

+17
-0
lines changed

charts/athens-proxy/README.md

+3
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,9 @@ This will deploy a single Athens instance in the `athens` namespace with `disk`
119119
| strategy.rollingUpdate.maxUnavailable | int | `1` | |
120120
| strategy.type | string | `"Recreate"` | Using RollingUpdate requires a shared storage |
121121
| tolerations | list | `[]` | see https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#scheduling |
122+
| tracing.enabled | bool | `false` | Set ATHENS_TRACE_EXPORTER* environment variables to point to a tracing deployment. |
123+
| tracing.type | string | `"jaeger"` | Value of ATHENS_TRACE_EXPORTER, supported values are "jaeger", "datadog", and "stackdriver". |
124+
| tracing.url | string | `""` | Value of ATHENS_TRACE_EXPORTER_URL |
122125
| upstreamProxy.enabled | bool | `false` | This is where you can set the URL for the upstream module repository. If 'enabled' is set to true, Athens will try to download modules from the upstream when it doesn't find them in its own storage. Here's a non-exhaustive list of options you can set here: - https://gocenter.io - https://proxy.golang.org |
123126
| upstreamProxy.url | string | `"https://gocenter.io"` | |
124127

charts/athens-proxy/templates/deployment.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,12 @@ spec:
192192
- name: ATHENS_TRACE_EXPORTER
193193
value: "jaeger"
194194
{{- end }}
195+
{{- if and .Values.tracing.enabled (not .Values.jaeger.enabled) }}
196+
- name: ATHENS_TRACE_EXPORTER_URL
197+
value: {{ .Values.tracing.url }}
198+
- name: ATHENS_TRACE_EXPORTER
199+
value: {{ .Values.tracing.type }}
200+
{{- end }}
195201
{{- if .Values.basicAuth.enabled }}
196202
- name: BASIC_AUTH_USER
197203
valueFrom:

charts/athens-proxy/values.yaml

+8
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,14 @@ jaeger:
171171
# With default settings, it uses the jaeger-collector-http port of the jaeger service.
172172
url: ""
173173

174+
tracing:
175+
# -- Set ATHENS_TRACE_EXPORTER* environment variables to point to a tracing deployment.
176+
enabled: false
177+
# -- Value of ATHENS_TRACE_EXPORTER_URL
178+
url: ""
179+
# -- Value of ATHENS_TRACE_EXPORTER, supported values are "jaeger", "datadog", and "stackdriver".
180+
type: "jaeger"
181+
174182
# -- Configuration for private git servers that will provide ssh and git config to athens in a ConfigMap
175183
sshGitServers: []
176184
## Private git servers over ssh

0 commit comments

Comments
 (0)