Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting a priority class name #56

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Allow setting a priority class name #56

merged 1 commit into from
Feb 16, 2024

Conversation

alex-bezek
Copy link
Contributor

Why

We run athens using this helm chart and would like to change its priority class in the cluster.

How

  • create a new value that defaults to empty
  • passively only add the priority class if specified
  • include an update to the Chart.yaml to trigger a release

Validation

❯ helm template charts/athens-proxy | grep priority
❯ helm template charts/athens-proxy --set priorityClassName=critical | grep priority
      priorityClassName: "critical"

@alex-bezek alex-bezek requested a review from a team as a code owner February 16, 2024 01:07
DrPsychick
DrPsychick approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@DrPsychick DrPsychick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution! 🎉

@DrPsychick DrPsychick merged commit a5b06b9 into gomods:main Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrPsychick DrPsychick DrPsychick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-bezek @DrPsychick