chore: use open telemetry bridge #1891
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in the linked issue, OpenCensus is to be replaced with OpenTelemetry. This can be tricky to do in a non-breaking way, and so the easiest thing to do for now is to use the OpenCensus bridge. https://opentelemetry.io/blog/2023/sunsetting-opencensus/ https://github.com/open-telemetry/opentelemetry-go/tree/ac5639159f9c8ec161a93b1990e878c74022d49b/bridge/opencensus Fixes: gomods#1771
|
Please resolve conflicts. |
|
@manugupt1 Apologies, this is a draft PR. I am not sure it's ready for review. |
|
Oh sorry! I missed it too :) thanks for helping in the last few days with the project. |
|
Not a problem, thank you for taking the time to review my changes! 🙂 |
|
@uhthomas If you're willing to fix this PR up and have a way to test it (OpenCensus & OTel) I'm happy to help get it into our next milestone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
As described in the linked issue, OpenCensus is to be replaced with OpenTelemetry. This can be tricky to do in a non-breaking way, and so the easiest thing to do for now is to use the OpenCensus bridge.
https://opentelemetry.io/blog/2023/sunsetting-opencensus/
https://github.com/open-telemetry/opentelemetry-go/tree/ac5639159f9c8ec161a93b1990e878c74022d49b/bridge/opencensus
How is the fix applied?
See above.
What GitHub issue(s) does this PR fix or close?
Fixes: #1771