-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain vendor vs proxy #1427
Merged
Merged
Explain vendor vs proxy #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when to use athens or another proxy server
…explain-vendor-vs-proxy
…n-vendor-vs-proxy
… into explain-vendor-vs-proxy
arschles
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@schafer14 this looks great, thanks for it! 🚀 🎉 💚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
This is a followup pull request based on the suggestion from in Slack.
There have been a few questions in the recent past about when/why to use a
vendor directory instead of (or along with) Athens or another proxy.
How is the fix applied?
I added a section to the FAQ that explains some pros and cons for when to use
vendor and when to use a proxy server like Athens.
Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.
Fixes #1338
This is following up on PR #1340