Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain vendor vs proxy #1427

Merged
merged 18 commits into from
Nov 8, 2019
Merged

Conversation

schafer14
Copy link
Contributor

What is the problem I am trying to address?

This is a followup pull request based on the suggestion from in Slack.

There have been a few questions in the recent past about when/why to use a
vendor directory instead of (or along with) Athens or another proxy.

How is the fix applied?

I added a section to the FAQ that explains some pros and cons for when to use
vendor and when to use a proxy server like Athens.

Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.

Fixes #1338

This is following up on PR #1340

@schafer14 schafer14 requested a review from a team as a code owner October 18, 2019 22:05
Copy link
Member

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schafer14 this looks great, thanks for it! 🚀 :shipit: 🎉 💚

@arschles arschles merged commit c8d81b9 into gomods:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: make it easy to compare vendoring and athens
2 participants