You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
could we run a pre-push hook instead of pre-commit hook?
Currently the hook does only npm run lint and it takes a while.
could we also run npm format, preferably in a pre-push hook?
This would enforce consistency in the code layout which is always welcome.
what is causing the lint warning re typescript, and can we get rid of it easily?
learning-lit-signals % time npm run lint
> @gongfuio/[email protected] lint
> eslint src --ext .js,.astro
=============
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.3.0
YOUR TYPESCRIPT VERSION: 5.3.2
Please only submit bug reports when using the officially supported version.
=============
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Three questions:
pre-push
hook instead ofpre-commit
hook?Currently the hook does only
npm run lint
and it takes a while.run npm format
, preferably in apre-push
hook?This would enforce consistency in the code layout which is always welcome.
Beta Was this translation helpful? Give feedback.
All reactions