Skip to content
This repository has been archived by the owner on Jun 25, 2019. It is now read-only.

Add SDM120 meter type #37

Open
andig opened this issue May 8, 2018 · 7 comments
Open

Add SDM120 meter type #37

andig opened this issue May 8, 2018 · 7 comments

Comments

@andig
Copy link
Collaborator

andig commented May 8, 2018

As per mreschka@6c82a0b and mreschka@12dabdd

@andig
Copy link
Collaborator Author

andig commented May 14, 2018

ping @mreschka I'd like to understand if adding SDM120 to this repo would be a good idea. Could you kindly clarify what drawbacks there are using the existing SDM630 meter for SDM120 devices? Are there any:

  • logfile errors (due to failing meter queries)?
  • UI problems with the web ui (empty rows)?
  • API problems (improper handling of null values)?
  • other problems?

@andig
Copy link
Collaborator Author

andig commented Sep 21, 2018

ping @mreschka

@mreschka
Copy link

mreschka commented Oct 7, 2018

Hi @andig,

sorry, I forgot to respond to your first message, thanks for the ping.

No there are no problems with the sdm630 version für a 120 device. The motivation is performance. The sdm120 supports far less registers and I reduced the scheduler to theses ones only. I have in total 20 sdm120 meters and this boosts the update-rate more than 2 times.

Viele Grüße

Markus

@andig
Copy link
Collaborator Author

andig commented Oct 7, 2018

Hi Markus,

Thanks for the update, I can certainly see your use case. You're trying to push update rate as high as possible?

I'm looking into adding additional meters and e.g. inverters (#80) which would require to refactor the reading logic. I'm thinking to do block-wise register reading instead of single by single. In #46 I had in mind to do this automatically but #80 suggests that should be done in the meter definition.

If I get around to actually implement something- would you be interested in testing?

@andig
Copy link
Collaborator Author

andig commented Oct 10, 2018

@mreschka see #83 for an approach to do batch readings. Still needs to be implemented for other meter types.

@J-A-U
Copy link

J-A-U commented Dec 9, 2018

If I get around to actually implement something- would you be interested in testing?

Sure.

@andig
Copy link
Collaborator Author

andig commented Dec 10, 2018

@J-A-U its not a priority, I'll focus on finishing 0.8 for time being. The infrastructure for batch readings is already implemented though and will lend itself to improve readout speed for any meter type.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants