Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate shopify storefront name input, add .myshopify.com to element #120

Open
colinxr opened this issue Aug 25, 2020 · 4 comments
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@colinxr
Copy link

colinxr commented Aug 25, 2020

I can enter my store url and storefront API Token in the fields on the "Shopify" tab, but when I hit "Save Credentials", the page just flashes without any feedback.

When I navigate to desk and then click back to the Shopify Tab, the values I entered previously are gone, and the fields are just blank.

Worth mentioning, I added sanity to an existing vue project. The folder structure looks like this:

/project-root
- /sanity 
- /src
- /public
- /dist
- .env
- vue.config.js
- babel.config.js 
- package.json

I am new to Sanity, so please forgive any foolish mistakes. Any help much appreciated!

@good-idea
Copy link
Owner

Hiya, sorry about this, I'll look into it right now ~ i probably messed something up :|

@good-idea good-idea self-assigned this Aug 25, 2020
@trompx
Copy link

trompx commented Sep 24, 2020

Hey @good-idea,
Just to let you know that I am having the same issue, did you come up with a fix?
Thanks a lot for making the integration with shopify less painful by the way!

@trompx
Copy link

trompx commented Sep 24, 2020

The message to enter the shopify domain was a bit misleading. By looking at the request, we had to omit the .myshopify.com so just enter for instance myshop and not myshop.myshopify.com.

@good-idea
Copy link
Owner

Hey, sorry for the delay over here! I'm glad you figured it out ~ I'm going to change the title of this issue to auto-include the .myshopify.com text in the input field and add better validation to this field. Thank you for opening the issue and checking back in!

@good-idea good-idea changed the title Can't save Shopify credentials Validate shopify storefront name input, add .myshopify.com to element Oct 2, 2020
@good-idea good-idea added the enhancement New feature or request label Oct 2, 2020
@good-idea good-idea added this to the 1.0 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants