Feature: extend product variants

[good-idea]

In progress - working on adding product variants as an array of sub-fields to the Sanity documents, allowing you to extend on these variants. For instance, adding a separate descriptions or galleries of images.

[good-idea]

@homerjam: from #22

Also I know you have your own roadmap so maybe I'll attempt to tackle this myself but variants are higher up the priority list than deletions for me!

This is higher on my list as well. Is there anything in particular you're trying to achieve?

[homerjam]

It's early stages of the project so we're still planning things out but the store will have products with lots of variables, I wouldn't say there's anything particular - storing the sourceData as you're doing now should suffice I think. My only concern there is (as was pointed out in the round table video) that this could end up binding the project to a particular Storefront API version. Shopify has been rapidly changing so I wonder if there's anything sensible we could do to mitigate this - perhaps even creating our own product/variant/collection schemas rather than storing all the nodes/edges as is.

[good-idea]

Yeah, that API is kind of all over the place. I just realized that the code was using the /api/graphql endpoint - I've locked it into 2020-01 for now. Moving forward, updating this will require checking if there are any breaking changes to the Storefront API that would affect sourceData - if so, that would be a breaking change for people relying on sourceData, and we would version appropriately.

[chanmathew]

Just chiming in on how our store uses variants:

We currently have products that are 1-pack or 2-pack, and customers can choose either, with different pricing and images. So being able to pull these in and read the right images, maybe add additional fields to each variants for additional frontend rendering/logic would be pretty helpful.

[good-idea]

Done in #44

please give it a shot!

[chanmathew]

Just upgraded and now when I compile the Studio I get this error:

Unknown type: productVariant. Valid types are: shopifyImageEdge, shopifySourceImages, shopifySourceImage, saneProductOption, saneMoney, saneProductPriceRange, collectionsConnection, productVariantEdge, productVariantEdges, productVariantsConnection, shopifyProductSource, selectedOption, shopifyProductVariantSource, productsConnection, shopifyCollectionSource, linkedCollections, pageInfo, shopifyNode, edge, shopifyEdges, shopifyProduct, shopifyCollection, array, block, boolean, datetime, date, document, email, file, geopoint, image, number, object, reference, slug, string, telephone, text and url

[good-idea]

There's another object you need to import - - see the note about 0.7.0 at the bottom the the Readme. Until 1.0 is released, minor version changes might be breaking - - - but I'll put notes in the Readme when there are things you need to do to migrate

…

On Sat, Jan 25, 2020, 10:12 PM Mathew Chan ***@***.***> wrote: Just upgraded and now when I compile the Studio I get this error: Unknown type: productVariant. Valid types are: shopifyImageEdge, shopifySourceImages, shopifySourceImage, saneProductOption, saneMoney, saneProductPriceRange, collectionsConnection, productVariantEdge, productVariantEdges, productVariantsConnection, shopifyProductSource, selectedOption, shopifyProductVariantSource, productsConnection, shopifyCollectionSource, linkedCollections, pageInfo, shopifyNode, edge, shopifyEdges, shopifyProduct, shopifyCollection, array, block, boolean, datetime, date, document, email, file, geopoint, image, number, object, reference, slug, string, telephone, text and url — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#33?email_source=notifications&email_token=ACX3IME6JO2N4UJIMT4DDCDQ7T5TLA5CNFSM4KHKMGE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5KWMI#issuecomment-578464561>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACX3IMCZWOIDDKWOUV3ANVTQ7T5TLANCNFSM4KHKMGEQ> .