Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup screen is displayed when there is an error connecting to the API #37

Open
good-idea opened this issue Jan 18, 2020 · 0 comments
Open
Labels
good first issue Good for newcomers help wanted Extra attention is needed scope:sanity-plugin
Milestone

Comments

@good-idea
Copy link
Owner

I discovered this after updating the URL in use from https://your-storefront-name.myshopify.com/api/graphql to /api/2020-01/graphql. According to the shopify docs, this should work, but it doesn't. Anyway, it shows the Setup screen instead of a displaying some kind of error about connecting to the API:

image

A request with a bad token will also return an error - so, we'll need to differentiate between that error and other that are just not connecting in the first place, either because the URL is somehow bad (maybe the storefront name changed, but it hasn't been updated in sanity), or the request is somehow blocked in another way.

@good-idea good-idea added help wanted Extra attention is needed good first issue Good for newcomers scope:sanity-plugin labels Jan 18, 2020
@good-idea good-idea added this to the 1.0 milestone Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed scope:sanity-plugin
Projects
None yet
Development

No branches or pull requests

1 participant