Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the portal (close) API? #3

Open
goodboy opened this issue Jul 6, 2018 · 3 comments
Open

Enhance the portal (close) API? #3

goodboy opened this issue Jul 6, 2018 · 3 comments

Comments

@goodboy
Copy link
Owner

goodboy commented Jul 6, 2018

I ran into problems trying to get channels to reliably tear down using StreamSocket.aclose() as per python-trio/trio/pull/460.

@njsmith was very helpful in pointing out that until this is resolved streams need to be cancelled using a separate scope / task which is what I ended up doing with open_portal() but I feel like this can be made even fancier according to his answer on SO.

Definitely worth toying with.
@goodboy
Copy link
Owner Author

goodboy commented Jul 6, 2018

Also @nonsleepr on July 6, 2018 10:30 AM came up with an example that might not require the extra nursery.

@goodboy
Copy link
Owner Author

goodboy commented Jul 25, 2018 •
edited
Loading

python-trio/trio#460 Is in so we can toy with dropping the extra nursery that was added to work around the underlying issue.

@goodboy
Copy link
Owner Author

goodboy commented Apr 28, 2021

This probably also ties into #206.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goodboy