trio.Process deprecations

[goodboy]

trio changed it's subprocess API as per the large discussion in
python-trio/trio#1104.

Summary:

• they dropped the Process.aclose() behaviour due to it being "surprising",
  prone to bugs and,

  Process.aclose was always just a convenience wrapper around other
  existing public APIs, and that hasn't changed.
  as per comment: process = await nursery.start(run_process, ...) python-trio/trio#1568 (comment)

• changed the run_process() API to allow for calling via a
  process = await nursery.start(run_process, ...) style and a new
  deliver_cancel() callback api from:
  process = await nursery.start(run_process, ...) python-trio/trio#1568
  • i commented here, and this might be a way for us to simplify our
    implementation by leveraging the now existing shielded-nursery-spawns-killer-task style
    which is more or less what we implemented before this APi landed:
    process = await nursery.start(run_process, ...) python-trio/trio#1568 (review)
    • currently the default impls don't close the stdstreams on a hard
      kill? I'll be copying that in from the old Process.aclose() in
      the interim.

home/goodboy/repos/tractor/tractor/_spawn.py:191: TrioDeprecationWarning: using trio.Process as an async context manager is deprecated since Trio 0.20.0; use run_process or nursery.start(run_process, ...) instead (https://github.com/python-trio/trio/issues/1104)
  async with proc:  # calls ``trio.Process.aclose()``
/home/goodboy/.virtualenvs/xonsh310/lib/python3.10/site-packages/trio/_abc.py:261: TrioDeprecationWarning: trio.Process.aclose is deprecated since Trio 0.20.0; use run_process or nursery.start(run_process, ...) instead (https://github.com/python-trio/trio/issues/1104)
  await self.aclose()

---

Mostly comprehensive list of related trio issues & PRs:

• Should we have a conventional way to "spawn a process into a nursery"? python-trio/trio#1104
• Allow customization of run_process cancellation behavior python-trio/trio#1525
• What should run_process do if it's cancelled but it can't kill the child process? python-trio/trio#1209
• process = await nursery.start(run_process, ...) python-trio/trio#1568 (comment)
• Should we have a conventional way to "spawn a process into a nursery"? python-trio/trio#1104