Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glfw name when using system installed version #351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JafarAbdi
Copy link

@JafarAbdi JafarAbdi commented Nov 8, 2024

Fix finding the library when setting -DMJPC_USE_SYSTEM_GLFW=ON to use the system glfw, similar to https://github.com/google-deepmind/mujoco/blob/088079eff0450e32b98ee743141780ed68307506/simulate/cmake/SimulateDependencies.cmake#L77-L91

Copy link

google-cla bot commented Nov 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nimrod-gileadi nimrod-gileadi self-requested a review November 25, 2024 14:02
Copy link
Collaborator

@nimrod-gileadi nimrod-gileadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants