Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button colors - mismatch between hints and solution #33

Open
fornaeffe opened this issue Jul 18, 2023 · 0 comments
Open

Button colors - mismatch between hints and solution #33

fornaeffe opened this issue Jul 18, 2023 · 0 comments

Comments

@fornaeffe
Copy link

Hi, I'm a newbye trying to learn Android Basics with Compose course;
I finished the codelab "Click behavior", but I noticed a mismatch between the hints, the pictures of the desired outcome and the solution code.

In hints you suggest to add Modifier.clickable() to the Image composable, but in the solution code you wrapped a Button around the Image.
Also in the same hint page you suggest to add a border (2dp, 4dp rounded corners, color = Color(105, 205, 216)) around the image, but the visual effect it's very different from the pictures of the desired output, that instead I obtain with the solution code.

I managed to succesfully finish the codelab, but I think that it will be far more easy if hints are coherent with solution code.

I addition, I noticed that solution code uses Material theme colors, still not treated in the course: I think that will be more understandable for beginners to use color resources...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant