Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Theming: Android Basics with Compose #116

Open
kihuha opened this issue Dec 17, 2024 · 0 comments
Open

Material Theming: Android Basics with Compose #116

kihuha opened this issue Dec 17, 2024 · 0 comments

Comments

@kihuha
Copy link

kihuha commented Dec 17, 2024

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-material-theming?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-3-pathway-3%3F_gl%3D1*164nxuk*_up*MQ..*_ga*NDU3NTQzMzM2LjE3MzQ0MTg0MDU.*_ga_6HH9YJMN9M*MTczNDQxODQwNS4xLjAuMTczNDQxODQwNy4wLjAuMTA0Mjk2MDYyMA..%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-material-theming&_gl=1*p7w2yv*_up*MQ..*_ga*NDU3NTQzMzM2LjE3MzQ0MTg0MDU.*_ga_6HH9YJMN9M*MTczNDQxODQwNS4xLjAuMTczNDQxODQwNy4wLjAuMTA0Mjk2MDYyMA..#3

In which task and step of the codelab can this issue be found?
Task 4

Describe the problem
In the "Dimens file" section, the codelab instructs that we should add a padding value read from the dimens file so that the result will be more definition between the list items in the UI. However, padding introduces space within the component and not between the component and the result in the WoofPreview() is not the same as the screenshot provided.

Steps to reproduce?

  1. Get the starter code and follow the steps described in the colab up to task 4
  2. In WoofApp(), add a modifier with padding_small in the call to DogItem() as described by the colab in section "Dimens file"
  3. The preview will show that padding was added but there is no definition between the list items

Versions
Android Studio Ladybug | 2024.2.1 Patch 3

Additional information
Result of adding padding:

Screenshot_20241217_074427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant