Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified_dmlab patch missing #10

Open
gary1346aa opened this issue Jun 23, 2021 · 5 comments
Open

modified_dmlab patch missing #10

gary1346aa opened this issue Jun 23, 2021 · 5 comments

Comments

@gary1346aa
Copy link

Hello,

I'm trying to build the modified DMLab, but when I apply the modified patch, it says
"no such file or directory"

seems that the patch doesn't exist anymore, can you re-upload it again? thanks!

@RaphaelMarinier
Copy link
Collaborator

The path is there:
https://github.com/google-research/episodic-curiosity/blob/master/third_party/dmlab/dmlab_min_goal_distance.patch

Maybe you tried the wrong command to apply it? Maybe you could describe the steps you performed to apply it?

@gary1346aa
Copy link
Author

I deleted and followed the steps again, now it shows other error, here's a screenshot of the steps I performed:

image

@GittiHab
Copy link

I could successfully apply the path by following the instructions in the readme:

git clone https://github.com/deepmind/lab
cd lab
git checkout 7b851dcbf6171fa184bf8a25bf2c87fe6d3f5380
git checkout -b modified_dmlab
git apply ../third_party/dmlab/dmlab_min_goal_distance.patch

Installing it as a pip module was a bit tricky though.

@GittiHab
Copy link

Looking at your error log, I would recommend that you simply start the installation from a clean clone. So delete your lab directory and then run all the steps again.

@GittiHab
Copy link

I also made a more detailed instruction on how to build the DM Lab module since I ran into a few issues there. Maybe this also helps others. I posted it over in the DM Lab repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants