Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telnet server accumulated dead connections #385

Open
cpcallen opened this issue Jun 10, 2020 · 2 comments
Open

Telnet server accumulated dead connections #385

cpcallen opened this issue Jun 10, 2020 · 2 comments
Labels
bug core Things related to the "core" part of the database
Milestone

Comments

@cpcallen
Copy link
Collaborator

Because:

  • There is no builtin to get a list of open connections, and
  • There is no builtin to test to see if a given connection is still open, and
  • There are certain circumstances under which the .onClose method of a connection object may not be successfully run to completion (such as when the connection is closed by virtue of the server being shut down)

there is a tendency for $.servers.telnet.connections to fill up with a lot of cruft, which in turn shows up on the $.console display.

Some effort was made previously to mitigate this, but it has evidently not been sufficient. See if it's possible to make this work well-enough in-database, or open a new bug to provide the necessary builtins.

@cpcallen cpcallen added the core Things related to the "core" part of the database label Jun 10, 2020
@cpcallen cpcallen added this to the Launch: Alpha milestone Jun 10, 2020
@cpcallen cpcallen added the bug label Jun 10, 2020
@cpcallen
Copy link
Collaborator Author

I've created$.servers.telnet.validate, which, along with related changes to $.servers.telnet.connection and its prototype $.connection, should keep the list of connected connections reasonably accurate.

cpcallen added a commit that referenced this issue Jun 12, 2020
Changes from 2020-06-12T13.38.01.309Z.city.

Closes: #360, #385.
cpcallen added a commit that referenced this issue Jun 15, 2020
Changes from 2020-06-12T13.38.01.309Z.city.

Closes: #360, #385.
@cpcallen
Copy link
Collaborator Author

Seems like this is not fixed: there's a whole bunch of / connections listed on the console again.

@cpcallen cpcallen reopened this Jun 18, 2020
cpcallen added a commit that referenced this issue Jun 24, 2020
Changes from 2020-06-12T13.38.01.309Z.city.

Closes: #360, #385.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core Things related to the "core" part of the database
Projects
None yet
Development

No branches or pull requests

1 participant