Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSSP, SVG and String editors should accept single-quoted strings #449

Open
cpcallen opened this issue Feb 12, 2021 · 0 comments
Open

JSSP, SVG and String editors should accept single-quoted strings #449

cpcallen opened this issue Feb 12, 2021 · 0 comments
Labels
/code Client-side issues related to the /code IDE.

Comments

@cpcallen
Copy link
Collaborator

cpcallen commented Feb 12, 2021

I made a modification to $.utils.code.toSource to use $.utils.code.quote instead of JSON.stringify to format strings (.quote prefers to use single quotes instead of double-quotes unless it would result in too many \'s), and in the process inadvertently broke the JSSP, SVG and String editors because they no longer comprehended the data to be edited.

Obviously I've reverted the change for now, and equally obviously it is a fool's errand to try to make the front ends fully general in what they can accept, but it would be nice for the editors to not be quite so dependent on the specifics of how the server chooses to represent the values to be edited.

@cpcallen cpcallen added the /code Client-side issues related to the /code IDE. label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
/code Client-side issues related to the /code IDE.
Projects
None yet
Development

No branches or pull requests

1 participant