Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

Maven build is failing due to the addition of kotlin #46

Open
cgruber opened this issue Sep 8, 2018 · 5 comments
Open

Maven build is failing due to the addition of kotlin #46

cgruber opened this issue Sep 8, 2018 · 5 comments
Assignees
Labels

Comments

@cgruber
Copy link
Contributor

cgruber commented Sep 8, 2018

For some reason the Kotlin maven plugin (specifically kapt) isn't running correctly - it either processes teh dagger annotation processor in addition to javac doing so, OR (if we exclude the javac build) it doesn't seem to process.

I'm not at Google anymore, as of today, but I"ll try to roll a fix and secure the help of googlers to upstream it.

@cgruber cgruber self-assigned this Sep 8, 2018
@cgruber cgruber added the bug label Sep 8, 2018
@cgruber
Copy link
Contributor Author

cgruber commented Sep 8, 2018

@ngzhian - I'll try to coordinate with you once I've figured it out. Hopefully it'll just be pom changes which are trivial to diff/patch into google's internal codebase.

@cgruber
Copy link
Contributor Author

cgruber commented Dec 10, 2018

Sorry it took so long to get on my feet again, after moving to Square. I'll try to fix this up soon.

@ngzhian
Copy link
Contributor

ngzhian commented Dec 13, 2018

Hey @cgruber heads up, we reverted the kotlin stuff internally, but didn't push it out yet, your work will diverge, i don't know what's the story there yet...

@cgruber
Copy link
Contributor Author

cgruber commented Feb 17, 2019

Ok. I have a totally separate PR to bazelize which I finally figured out and fixed all the kotlin stuff too. I'm wondering if we want to keep these in sync, or if I should just perma-fork.

@cgruber
Copy link
Contributor Author

cgruber commented Feb 17, 2019

Especially given that i'm planning to basically re-write it in Kotlin, and fix quite a few design issues along the way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants