Make ExtendsAutoValue an ERROR.

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=283030476
google · Dec 2, 2019 · 36713f5 · 36713f5
1 parent 2230bd1
commit 36713f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/ExtendsAutoValue.java b/core/src/main/java/com/google/errorprone/bugpatterns/ExtendsAutoValue.java
@@ -31,7 +31,7 @@
 @BugPattern(
     name = "ExtendsAutoValue",
     summary = "Do not extend an @AutoValue/@AutoOneOf class in non-generated code.",
-    severity = SeverityLevel.WARNING)
+    severity = SeverityLevel.ERROR)
 public final class ExtendsAutoValue extends BugChecker implements ClassTreeMatcher {
 
   private static final Supplier<ImmutableSet<Name>> AUTOS =

diff --git a/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java b/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java
@@ -518,6 +518,7 @@ public static ScannerSupplier errorChecks() {
           EqualsNaN.class,
           EqualsReference.class,
           EqualsWrongThing.class,
+          ExtendsAutoValue.class,
           ForOverrideChecker.class,
           FormatString.class,
           FormatStringAnnotationChecker.class,
@@ -661,7 +662,6 @@ public static ScannerSupplier errorChecks() {
           EqualsUnsafeCast.class,
           EqualsUsingHashCode.class,
           ExtendingJUnitAssert.class,
-          ExtendsAutoValue.class,
           FallThrough.class,
           Finally.class,
           FloatCast.class,