From 6203a0eea4abaec9356fef6a2723a42057775055 Mon Sep 17 00:00:00 2001
From: Liam Miller-Cushon <cushon@google.com>
Date: Thu, 17 Oct 2024 08:02:46 -0700
Subject: [PATCH] Remove references to `-XDshouldStopPolicyIfError` now that
 `--should-stop=ifError=FLOW` is the default

As pointed out in https://github.com/google/error-prone/pull/4618#issuecomment-2417416777

PiperOrigin-RevId: 686916247
---
 .../google/errorprone/ErrorProneCompilerIntegrationTest.java   | 3 ---
 .../com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/core/src/test/java/com/google/errorprone/ErrorProneCompilerIntegrationTest.java b/core/src/test/java/com/google/errorprone/ErrorProneCompilerIntegrationTest.java
index fa3740d18d5..0574fb186cd 100644
--- a/core/src/test/java/com/google/errorprone/ErrorProneCompilerIntegrationTest.java
+++ b/core/src/test/java/com/google/errorprone/ErrorProneCompilerIntegrationTest.java
@@ -581,9 +581,6 @@ public void compilationWithError() {
     compiler = compilerBuilder.build();
     Result exitCode =
         compiler.compile(
-            new String[] {
-              "-XDshouldStopPolicyIfError=LOWER",
-            },
             Arrays.asList(
                 forSourceLines(
                     "Test.java",
diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java
index 827b2c1724c..abacd96eb07 100644
--- a/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java
+++ b/core/src/test/java/com/google/errorprone/bugpatterns/FieldCanBeFinalTest.java
@@ -17,7 +17,6 @@
 
 import com.google.errorprone.CompilationTestHelper;
 import com.google.errorprone.annotations.Var;
-import java.util.Arrays;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -348,8 +347,6 @@ class B {
               }
             }
             """)
-        // hackily force processing of both compilation units so we can verify both diagnostics
-        .setArgs(Arrays.asList("-XDshouldStopPolicyIfError=FLOW"))
         .doTest();
   }