Ignore disabled checks passed to -XepPatchChecks

Rather than throwing an `NoSuchElementException`. Fixes #3908. Fixes #4028 FUTURE_COPYBARA_INTEGRATE_REVIEW=#4028 from PicnicSupermarket:gdejong/remove-disabled-checks 4d502e0 PiperOrigin-RevId: 563488388
google · Sep 8, 2023 · c900f13 · c900f13
1 parent 5c5ec33
commit c900f13
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 4 deletions.
diff --git a/check_api/src/main/java/com/google/errorprone/BaseErrorProneJavaCompiler.java b/check_api/src/main/java/com/google/errorprone/BaseErrorProneJavaCompiler.java
@@ -227,14 +227,12 @@ static ErrorProneAnalyzer createAnalyzer(
             .customRefactorer()
             .or(
                 () -> {
-                  ScannerSupplier toUse =
-                      ErrorPronePlugins.loadPlugins(scannerSupplier, context)
-                          .applyOverrides(epOptions);
+                  ScannerSupplier toUse = ErrorPronePlugins.loadPlugins(scannerSupplier, context);
                   ImmutableSet<String> namedCheckers = epOptions.patchingOptions().namedCheckers();
                   if (!namedCheckers.isEmpty()) {
                     toUse = toUse.filter(bci -> namedCheckers.contains(bci.canonicalName()));
                   }
-                  return ErrorProneScannerTransformer.create(toUse.get());
+                  return ErrorProneScannerTransformer.create(toUse.applyOverrides(epOptions).get());
                 })
             .get();
 

diff --git a/core/src/test/java/com/google/errorprone/scanner/ScannerTest.java b/core/src/test/java/com/google/errorprone/scanner/ScannerTest.java
@@ -95,6 +95,22 @@ public void suppressionAnnotationIgnoredWithOptions() {
         .doTest();
   }
 
+  @Test
+  public void dontRunPatchForDisabledChecks() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            "import com.google.errorprone.scanner.ScannerTest.Foo;",
+            "class Test {",
+            "  Foo foo;",
+            "}")
+        .setArgs(
+            "-XepPatchLocation:IN_PLACE",
+            "-XepPatchChecks:ShouldNotUseFoo",
+            "-Xep:ShouldNotUseFoo:OFF")
+        .doTest();
+  }
+
   @OkToUseFoo // Foo can use itself. But this shouldn't suppress errors on *usages* of Foo.
   public static final class Foo<T> {}