Fix a NPE in ByteBufferBackingArray

Fixes #1004 MOE_MIGRATED_REVID=193610886
google · Apr 20, 2018 · ea07060 · ea07060
1 parent 9010f1e
commit ea07060
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/ByteBufferBackingArray.java b/core/src/main/java/com/google/errorprone/bugpatterns/ByteBufferBackingArray.java
@@ -87,6 +87,9 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
     } while (receiver instanceof MethodInvocationTree);
 
     Symbol bufferSymbol = ASTHelpers.getSymbol(receiver);
+    if (bufferSymbol == null) {
+      return Description.NO_MATCH;
+    }
 
     // Checks for validating use on method scope.
     if (bufferSymbol.owner instanceof MethodSymbol) {

diff --git a/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java b/core/src/test/java/com/google/errorprone/bugpatterns/ByteBufferBackingArrayTest.java
@@ -43,4 +43,18 @@ public void testNegativeCases() throws Exception {
     compilationHelper.addSourceFile("ByteBufferBackingArrayNegativeCases.java").doTest();
   }
 
+
+  @Test
+  public void i1004() {
+    compilationHelper
+        .addSourceLines(
+            "Test.java",
+            "import java.nio.ByteBuffer;",
+            "public class Test {",
+            "  public void ByteBufferBackingArrayTest() {",
+            "    byte[] byteArray = ((ByteBuffer) new Object()).array();",
+            "  }",
+            "}")
+        .doTest();
+  }
 }