Migrate all unit test cases to Junit 5 platform

[chandrashekar-s]

Junit 5 platform offers few advantages over Junit 4 like Junit 5 uses some advanced features of Java, can execute via more Runners etc. Migrate all the unit tests to Junit 5.

[mdxabu]

@chandrashekar-s, can I work on it?

[chandrashekar-s]

Thanks @mdxabu for your interest. Yes, you can definitely work on it. Please feel free to assign this to yourself and start working on it. You could also join the Developer calls that happens every 2 weeks to discuss the status of this issue.

[chandrashekar-s]

Also, to make the development and review process easier, please change one module at a time and raise a PR.

[mdxabu]

@chandrashekar-s , Just change the Junit version on pom.xml right?

[chandrashekar-s]

@mdxabu Please use this PR as a sample reference where we migrated the test cases of controller module to Junit 5. You can also refer to this documentation for Migration from junit 4. Similar changes are expected in other modules as well.

[meetmehta1198]

Pull Request Submitted. Please provide your feedback!

#1135

[DAN-MU-ZI]

Hi @chandrashekar-s , @meetmehta1198 . I’ve been looking into this issue and would love to contribute!
From the PR, it seems like not all the test cases have been fully migrated to JUnit 5 yet. Would it be okay if I work on this part?
As this is my first contribution, I’m approaching this carefully and would appreciate any guidance or suggestions. Thank you!

[chandrashekar-s]

Hi @DAN-MU-ZI Thanks for showing your interest on this. Since @meetmehta1198 is already working on this, I will like to ask if @meetmehta1198 wants to continue on the remaining modules as well. However, there are other issues that you can have a look as well, like this #632 and this #257 . Please let me know if you would like to contribute to any of these. Thanks!

[DAN-MU-ZI]

Hi @chandrashekar-s,

I’ve been reviewing issue #632, and I believe I can contribute to it. I’m currently going through the project documentation and related code to better understand the scope of the work required.

Additionally, I noticed that the path for ApiController.java seems to have changed. It appears that the previous path:
https://github.com/google/fhir-data-pipes/blob/master/pipelines/controller/src/main/java/org/openmrs/analytics/ApiController.java
has been updated to:
https://github.com/google/fhir-data-pipes/blob/master/pipelines/controller/src/main/java/com/google/fhir/analytics/ApiController.java.

Please let me know if this is correct or if I might be missing something.

Once I have a clearer understanding of the project structure, I’ll make sure to follow up with a detailed response. If there are any additional resources or key points I should be aware of, I’d greatly appreciate it if you could share them.

Thank you!

[DAN-MU-ZI]

Hello @chandrashekar-s,
I previously showed interest in this issue, but after reviewing it, I’ve realized that I’m unable to contribute effectively at this time. The task seems too challenging for me to handle.