From 528033da0875883390c4f9cc7f7415fc4cdd0ba1 Mon Sep 17 00:00:00 2001 From: Xinhao Yuan Date: Wed, 22 Jan 2025 08:27:50 -0800 Subject: [PATCH] Fix the inherited Fuzzer class for the compatibility mode. PiperOrigin-RevId: 718396494 --- fuzztest/internal/compatibility_mode.cc | 8 ++++---- fuzztest/internal/compatibility_mode.h | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/fuzztest/internal/compatibility_mode.cc b/fuzztest/internal/compatibility_mode.cc index dc979dcc..2a321fdd 100644 --- a/fuzztest/internal/compatibility_mode.cc +++ b/fuzztest/internal/compatibility_mode.cc @@ -65,12 +65,12 @@ FuzzTestExternalEngineAdaptor::FuzzTestExternalEngineAdaptor( const FuzzTest& test, std::unique_ptr fixture_driver) : test_(test), fixture_driver_staging_(std::move(fixture_driver)) {} -void FuzzTestExternalEngineAdaptor::RunInUnitTestMode( +bool FuzzTestExternalEngineAdaptor::RunInUnitTestMode( const Configuration& configuration) { - GetFuzzerImpl().RunInUnitTestMode(configuration); + return GetFuzzerImpl().RunInUnitTestMode(configuration); } -int FuzzTestExternalEngineAdaptor::RunInFuzzingMode( +bool FuzzTestExternalEngineAdaptor::RunInFuzzingMode( int* argc, char*** argv, const Configuration& configuration) { FUZZTEST_INTERNAL_CHECK(&LLVMFuzzerRunDriver, "LibFuzzer Driver API not defined."); @@ -101,7 +101,7 @@ int FuzzTestExternalEngineAdaptor::RunInFuzzingMode( "Invalid fixture driver!"); impl.fixture_driver_->TearDownFuzzTest(); - return 0; + return true; } // External engine callbacks. diff --git a/fuzztest/internal/compatibility_mode.h b/fuzztest/internal/compatibility_mode.h index 5fb7b595..98166312 100644 --- a/fuzztest/internal/compatibility_mode.h +++ b/fuzztest/internal/compatibility_mode.h @@ -75,9 +75,9 @@ class FuzzTestExternalEngineAdaptor : public FuzzTestFuzzer, FuzzTestExternalEngineAdaptor(const FuzzTest& test, std::unique_ptr fixture_driver); - void RunInUnitTestMode(const Configuration& configuration) override; - int RunInFuzzingMode(int* argc, char*** argv, - const Configuration& configuration) override; + bool RunInUnitTestMode(const Configuration& configuration) override; + bool RunInFuzzingMode(int* argc, char*** argv, + const Configuration& configuration) override; // External engine callbacks.