Fix for deletion of instances in multi-instance program.

google · Nov 5, 2020 · bee6c18 · bee6c18
1 parent 52e6888
commit bee6c18
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/gapis/api/vulkan/api/instance.api b/gapis/api/vulkan/api/instance.api
@@ -81,7 +81,9 @@ cmd void vkDestroyInstance(
     AllocationCallbacks          pAllocator) {
   delete(Instances, instance)
   for _, device, _ in PhysicalDevices {
-    delete(PhysicalDevices, device)
+    if (PhysicalDevices[device].Instance == instance) {
+      delete(PhysicalDevices, device)
+    }
   }
 }
 

diff --git a/gapis/api/vulkan/synthetic.api b/gapis/api/vulkan/synthetic.api
@@ -38,7 +38,9 @@ cmd void replayDestroyVkInstance(
   // vkDestroyInstance() in vulkan.api. Change both together
   delete(Instances, instance)
   for _, device, _ in PhysicalDevices {
-    delete(PhysicalDevices, device)
+    if (PhysicalDevices[device].Instance == instance) {
+      delete(PhysicalDevices, device)
+    }
   }
 }