Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp flag for request, comment, accept #109

Open
yawaramin opened this issue Jan 12, 2022 · 1 comment
Open

Add timestamp flag for request, comment, accept #109

yawaramin opened this issue Jan 12, 2022 · 1 comment

Comments

@yawaramin
Copy link

I propose to add an optional -timestamp flag to the following commands:

  • git appraise request
  • git appraise comment
  • git appraise accept

If the flag is not specified, it will default to the current timestamp. The timestamp will then be used for the request and comment JSON objects.

This will make it easy to script importing historical code reviews from other systems. No special code will be required, just normal shell commands. (User can be easily set in the shell with git config.)

@yawaramin yawaramin changed the title Add timstamp flag for request, comment, accept Add timestamp flag for request, comment, accept Jan 12, 2022
@ojarjur
Copy link
Collaborator

ojarjur commented Jan 25, 2022

Thanks for the suggestion!

Importing review data from other tools is an important use case and we only really support it well for GitHub pull requests (using the PR mirror).

I agree that this would make building other such import pipelines (especially one-offs) much easier, so it would be a good change.

It looks like git has settled on naming such a flag --date, so we should use that same name to maintain consistency.

It would be even better if we also supported the same environment variables that git supports (GIT_AUTHOR_DATE, and maybe GIT_COMMITTER_DATE too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants